Skip to content

aa - #120

Merged
winnerspiros merged 3 commits into
winnerspiros:masterfrom
ppy:master
Mar 30, 2026
Merged

aa#120
winnerspiros merged 3 commits into
winnerspiros:masterfrom
ppy:master

Conversation

@winnerspiros

@winnerspiros winnerspiros commented Mar 30, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary by Gitar

This will update automatically on new commits.

Summary by CodeRabbit

  • Improvements
    • Streamlined installation migration workflow when detecting existing installs
    • Updated ranked play card display and loading behavior
    • Refined UI behavior for multiplayer readiness controls

Joehuu and others added 3 commits March 29, 2026 23:41
@Joehuu
Remove "cancel countdown" tooltip on multiplayer ready button (#37143)
11a7855 
- Closes #37142

Not relevant anymore after
9963efc.
@Joehuu
Only show one dialog and automatically restart when changing folder t…
940848e 
…o already installed location (#37137)

- Closes #37039


https://github.com/user-attachments/assets/eb788984-783c-42ac-a7db-e6daa64d609d

Can't gracefully exit because main menu has another exit confirmation
dialog. May need to revisit #26558.
Unless force exiting is intentional?
@peppy
Adjust RankedPlayCard to always show card back (when loading conten…
ee2f7a7 
…t) (#37129)

This was mentioned in vivi's feedback. Basically now the card backside
is always loaded and there, rather than faffing with switching the
content around.

> Cards have a stale grey background when they are spawning in before
they get changed into the cards they’re supposed to be. This can be
changed to the backside of the card or maybe a bright white card. Makes
it look less placeholdery.

Keeping it simple for now. Can probably hide it when not in use in the
future.
@winnerspiros
winnerspiros merged commit 408b05d into winnerspiros:master Mar 30, 2026
1 of 9 checks passed
@coderabbitai

coderabbitai Bot commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 263a8c66-cda5-48ed-acb5-dc00a85b17a4

📥 Commits

Reviewing files that changed from the base of the PR and between 4835806 and ee2f7a7.

📒 Files selected for processing (7)
  • osu.Game.Tests/Visual/RankedPlay/TestSceneDiscardScreen.cs
  • osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs
  • osu.Game.Tests/Visual/RankedPlay/TestScenePickScreen.cs
  • osu.Game/Localisation/MaintenanceSettingsStrings.cs
  • osu.Game/Overlays/Settings/Sections/Maintenance/MigrationSelectScreen.cs
  • osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Card/RankedPlayCard.cs
  • osu.Game/Screens/OnlinePlay/Multiplayer/Match/MultiplayerReadyButton.cs
📝 Walkthrough

Walkthrough

Test scenes for ranked play are updated to use RankedPlayTestScene base class and now configure beatmap request handlers with programmatic card reveals. RankedPlayCard component is refactored to simplify flip-state logic. Migration confirmation flow consolidates dialogs. Localization strings and ready button tooltip override are adjusted.

Changes

Cohort / File(s) Summary
RankedPlay Test Scene Updates
osu.Game.Tests/Visual/RankedPlay/TestSceneDiscardScreen.cs, osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs, osu.Game.Tests/Visual/RankedPlay/TestScenePickScreen.cs		 Base class changed to RankedPlayTestScene. Each test now instantiates BeatmapRequestHandler, assigns it to DummyAPIAccess.HandleRequest, adds a wait step, and reveals 5 cards by binding beatmap IDs from request handler data.
RankedPlayCard Refactoring
osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Card/RankedPlayCard.cs		 Simplified state management by removing flip parameter from public/private methods. Back side now always initialized; content starts as Empty(). Replaced loadCardContent() with loadCardContentAsync() and refactored SetContent() signature to accept nullable drawable without flip flag.
Maintenance & Migration Updates
osu.Game/Localisation/MaintenanceSettingsStrings.cs, osu.Game/Overlays/Settings/Sections/Maintenance/MigrationSelectScreen.cs		 Removed RestartAndReOpenRequiredForCompletion string; merged restart message into TargetDirectoryAlreadyInstalledOsu. Migration dialog consolidated to single confirmation layer with direct RestartAppWhenExited() call on accept.
Ready Button Cleanup
osu.Game/Screens/OnlinePlay/Multiplayer/Match/MultiplayerReadyButton.cs		 Removed TooltipText override, eliminating conditional "Cancel countdown" text logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 Cards flip less, but show much more,
Tests now unified at the core,
Migrations seamless, dialogs pare,
Tooltips vanish—cleaner air! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced Apr 2, 2026
Merged
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Apr 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@winnerspiros @Joehuu @peppy